Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #1778

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Documenter package from 0.26, 0.27 to 0.26, 0.27, 1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@andreasnoack andreasnoack force-pushed the compathelper/new_version/2023-09-16-00-05-54-816-00041392826 branch from 97a74c2 to f66eb4f Compare September 16, 2023 00:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (a1010e4) to head (cf45ea3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files         144      144           
  Lines        8696     8696           
=======================================
  Hits         7486     7486           
  Misses       1210     1210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm
Copy link

(@devmotion, as you're the most active committer!) would it be possible to merge this please? Documenter v1.3 would generate a nice objects.inv file which lets us link to Distributions docs easily 🙂

@penelopeysm
Copy link

I checked it locally and this PR would probably also need a warnonly=true keyword argument to be added to makedocs(), as Documenter 1.x upgrades the warnings to errors by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants